-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark ondragexit handler and dragexit event as standard_track:false, and deprecated:true #6710
Conversation
api/Document.json
Outdated
@@ -3370,55 +3370,6 @@ | |||
} | |||
} | |||
}, | |||
"dragexit_event": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should we not keep this entry, and have it be in sync with the ondragexit
entry? @ddbeck is there a guidelines for when to have each type of entry, and on what interfaces they should be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure what it means that onrdagexit
is supported, but the dragexit
event is not. @sideshowbarker can you elaborate on this?
My instinct says that if there's an event handler then there's probably a corresponding event (unless the event handler receives a different event, or some other oddity), but I don't actually know a lot about event APIs, so I don't know if that's a helpful instinct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- "dragexit_event": {
Why should we not keep this entry, and have it be in sync with the
ondragexit
entry?
My preference would be to delete the ondragexit
entry too. I don’t think we have evidence that developers are actually relying on it in any way in practice — we don’t have any evidence that they’d miss it if we dropped it.
I'm not quite sure what it means that
onrdagexit
is supported, but thedragexit
event is not. @sideshowbarker can you elaborate on this?
I believe the dragexit
event is supported in Gecko — it’s just that we never got around to documenting it as such in BCD. But it’s not supported in any other engines, and never will be. So it’s never been part of the web platform and never will be. For those reasons I don’t think it merits us going out of our way to retroactively document it in BCD in any way.
And given all that, my personal preference would be that we completely delete the ondragexit
data too. If we are able to get agreement about that, then I can also add that change to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I guess this is the story as I understand it:
- The data removed in this PR (the event itself) reports
false
for all browsers. But this data is erroneous, at least for Firefox—Gecko implemented it, but BCD never reflected that. - The PR leaves intact data for the
ondragexit
handler. The data for that is either strange in some way which we haven't documented (browsers other than Firefox useondragexit
as a handler for a different event or something else), or wrong (browsers other than Firefox don't implementondragexit
in any way).
But, if as you say, Firefox is the only browser that implemented ondragexit
and it's still available today (it seems to be, though I'm basing that solely on the console tab completion for ondragexit
), then we should:
- Have features for both
ondragexit
and thedragexit
event - Populate those features with
false
values for all the other browsers. If we're able to, set the correct values for Firefox, or open a help-wanted issue if we can't be bothered right now. - Set the status flags to show this is non-standard, non-experimental, and deprecated.
It's a bit of a bummer—I'd be happier if Firefox removed it so we could bin the features themselves—but I think that's what we're stuck with, if a browser is actually shipping it. In terms of documentation on MDN itself, I don't think it's worth anyone's time to actually update those docs, except maybe to add deprecation notices where there are pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, @sideshowbarker I realize I kinda dropped a wall of text on you here. Is this too much? As an alternative, we could pare this down to the status change only, then open an issue to address the feature data at a later time.
(or if you just hadn't got back to this yet, that's fine too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per Confluence, the ondragexit
event handler attributes are still in Firefox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an alternative, we could pare this down to the status change only
OK, I’ve amended and pushed the commit in this PR branch to only contain a change to the standard_track
and deprecated
values.
then open an issue to address the feature data at a later time.
OK, opened #6826 for that
Pulling this out from #6710 (comment) so that I can link to it later:
@ddbeck This is only usually right, and something odd is going on if a
One complication is that the event targets aren't necessarily the same as where the event handler attributes are. Take "volumechange" as an example: Even setting that complication aside, the two things can easily come apart in implementations. It's easy to forget to add the It's also possible to have the reverse problem, where one copy-pastes some event handler attributes into an implementation, but nothing ever fires those events. I don't have an example of that, but would be shocked if it hasn't happened. These distinctions are ones that most of the time one need not know about, but as long as BCD represents both things, reviewers will need to be aware of some of this. Perhaps we should write this down in a data guideline? |
1005d49
to
5318486
Compare
This change marks the ondragexit event handler and dragexit event as standard_track:false and deprecated:true — because they have been removed from the HTML spec: * whatwg/html@40e3868 * whatwg/html#2741
5318486
to
8095fcb
Compare
A real case of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this, @sideshowbarker. I'll try to get to #6826 soon, so that we can resolve the broader issues properly. 👍
This change marks the
ondragexit
event handler anddragexit
event as standard_track:false and deprecated:true — because they have now been removed from the HTML spec: