Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data for stage 3 iterator-helpers #20573

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Data for stage 3 iterator-helpers #20573

merged 5 commits into from
Aug 24, 2023

Conversation

Josh-Cena
Copy link
Member

@Josh-Cena Josh-Cena commented Aug 21, 2023 •
edited
Loading

Summary

mdn/content#28677

@chrisdavidmills The Chrome version needs to be updated. Is it 118? 117?

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Aug 21, 2023
@zloirock
Copy link

It's enabled by default in beta 117 and chromestatus shows it's shipped in 117.

image

@Josh-Cena
Copy link
Member Author

Thanks @zloirock. I updated the version. Hope this is how BCD works

chrisdavidmills
chrisdavidmills reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @Josh-Cena; just a few comments.

chrisdavidmills
chrisdavidmills requested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Josh-Cena just one more small nitpick.

@Josh-Cena
Copy link
Member Author

Neither of us have permissions to BCD so we'll have to wait for maintainers :(

chrisdavidmills
chrisdavidmills approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @Josh-Cena!

@bsmth
Copy link
Member

bsmth commented Aug 24, 2023

Thanks, all, merging shortly 👍🏻

@bsmth bsmth merged commit 1cd8b82 into mdn:main Aug 24, 2023
@Josh-Cena Josh-Cena deleted the iterator-helpers branch August 24, 2023 14:57
@zloirock
Copy link

zloirock commented Sep 1, 2023

V8 unshipped it https://bugs.chromium.org/p/chromium/issues/detail?id=1474613.

@Josh-Cena
Copy link
Member Author

I'm aware of the unfortunate situation: tc39/proposal-iterator-helpers#286

I'm not sure how it should be documented. Maybe just change chrome to false?

@syg
Copy link
Contributor

syg commented Sep 1, 2023

I'm not sure how it should be documented. Maybe just change chrome to false?

I'd stay tuned until next week, though I understand that's cutting it close. If Transcend can ship a fix on their CDN and we can confirm the fix, then Chrome will continue to ship in 117. Otherwise we will delay.

@Josh-Cena
Copy link
Member Author

Thanks! Please keep us posted so we may update the data accordingly.

@debiru debiru mentioned this pull request Dec 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Josh-Cena @zloirock @bsmth @syg @chrisdavidmills