Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACAS-786: Add restandardization check to SaltBrowser #1205

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

bffrost
Copy link
Collaborator

@bffrost bffrost commented Mar 4, 2025

Description

This PR adds the "allow cmpd registration" check that already exists on CReg single and bulk pages into the Salt Browser, since it also relies on chemistry services. Create, Edit, and Download buttons are disabled if compound registration is currently unavailable due to a need for a restandardization or due to unavailable chemistry services.

Related Issue

How Has This Been Tested?

Tested by switching local roo to bbchem mode and pointing at a remove bbchem instance, which triggered some errors / failures from the allowCmpdRegistration route.
The table is still visible but the buttons at the top are disabled
Screenshot 2025-03-04 at 3 33 20 PM

Viewing and deleting is still available but editing is blocked
Screenshot 2025-03-04 at 3 33 25 PM

Copy link
Contributor

@dalejerikson dalejerikson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@brianbolt brianbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bffrost bffrost merged commit ce0bc7e into master Mar 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants