Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACAS-814: Fix typo and styling on Salt browser/editor #1202

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

bffrost
Copy link
Collaborator

@bffrost bffrost commented Mar 4, 2025

Description

Reported issue was a typo in user instructions. I also noticed use of color on buttons was inconsistent with the rest of the app, and there was a layout issue with the confirmation buttons on the Edit salt confirmation dialog.

  • Fixed sepcify -> specify typo
  • Removed btn-primary and btn-danger classes from most buttons in the workflow so btn-danger is only used on Delete dialogs. Switched Save / Update dialogs to btn-success (green)
  • Removed the Cancel button from dialogs that had Back / Cancel / Save. The Back button already works to go backward and the wizard is only 2 steps deep, so I found the Cancel button to be unnecessary

Related Issue

How Has This Been Tested?

Manual testing. See video (sorry for low resolution):

ACAS-814.mov

Copy link
Contributor

@dalejerikson dalejerikson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@brianbolt brianbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the video, LGTM.

@bffrost bffrost merged commit ab733bf into master Mar 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants