Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply ctx abbreviation consistently #257

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Jan 9, 2024

Description

  • Small clean-up PR to use ctx instead of callback_context consistently to be less verbose and use official abbreviations, see here

Note: ctx shortcut currently doesn't exist for dash_clientside yet, so there we would use the old syntax. However, with this recent PR on Dash that got merged (but not released), we should be able to replace something like:

window.dash_clientside.callback_context.triggered[0].prop_id.split('.')[0] with
window.dash_clientside.callback_context.trigger_id in the future if we upgrade to the latest Dash version

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@huong-li-nguyen huong-li-nguyen enabled auto-merge (squash) January 10, 2024 09:28
@huong-li-nguyen huong-li-nguyen merged commit d64350c into main Jan 10, 2024
@huong-li-nguyen huong-li-nguyen deleted the tidy/use_ctx_short branch January 10, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants