Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] VizroAI whl pycafe tests #1046

Merged
merged 20 commits into from
Mar 6, 2025
Merged

Conversation

maxschulz-COL
Copy link
Contributor

@maxschulz-COL maxschulz-COL commented Mar 4, 2025

Description

I made this PR spontaneously, it doesn't have big impact, but it felt useful in that moment. It does the following:

  • it builds now also a whl file of the latest vizro-ai
  • it installs both the latest vizro and vizro-ai in one environment (so we can detect conflicts early)
  • it uses the latest vizro-ai whl file for all PyCafe examples from vizro-ai (and as such currently the vizro-ai UI fails, as the latest on main is not compatible with the pyodide version PyCafe is using

Open question: currently we only check the dev dashboard, should we also check a vizro-ai dashboard, ie one that contains that as dependency?

Pro:

  • would catch vizro-ai incompatibilities with PyCafe early

Con:

  • would also make vizro tests fail if such a thing occurs on main

Separating the tests for the two packages properly would be a lot of work, so that is not an option for me.

Decision: do not test a vizro-ai pycafe link, that remains manual

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@github-actions github-actions bot added the Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package label Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 6, 2025

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2025-03-06 10:06:50 UTC
Commit: 33615e9

Compare the examples using the commit's wheel file vs the latest released version:

vizro-core/examples/scratch_dev

View with commit's wheel vs View with latest release

vizro-core/examples/dev/

View with commit's wheel vs View with latest release

vizro-core/examples/visual-vocabulary/

View with commit's wheel vs View with latest release

vizro-core/examples/tutorial/

View with commit's wheel vs View with latest release

vizro-ai/examples/dashboard_ui/

View with commit's wheel vs View with latest release

@maxschulz-COL maxschulz-COL merged commit 0529453 into main Mar 6, 2025
41 checks passed
@maxschulz-COL maxschulz-COL deleted the qa/test_vizro_ai_in_pycafe branch March 6, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant