-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA] VizroAI whl pycafe tests #1046
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…o into qa/test_vizro_ai_in_pycafe
1 task
for more information, see https://pre-commit.ci
…o into qa/test_vizro_ai_in_pycafe
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2025-03-06 10:06:50 UTC Compare the examples using the commit's wheel file vs the latest released version: vizro-core/examples/scratch_devView with commit's wheel vs View with latest release vizro-core/examples/dev/View with commit's wheel vs View with latest release vizro-core/examples/visual-vocabulary/View with commit's wheel vs View with latest release vizro-core/examples/tutorial/View with commit's wheel vs View with latest release vizro-ai/examples/dashboard_ui/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I made this PR spontaneously, it doesn't have big impact, but it felt useful in that moment. It does the following:
vizro-ai
vizro
andvizro-ai
in one environment (so we can detect conflicts early)vizro-ai
whl file for all PyCafe examples fromvizro-ai
(and as such currently the vizro-ai UI fails, as the latest on main is not compatible with the pyodide version PyCafe is usingOpen question: currently we only check the
dev
dashboard, should we also check avizro-ai
dashboard, ie one that contains that as dependency?Pro:
vizro-ai
incompatibilities with PyCafe earlyCon:
vizro
tests fail if such a thing occurs onmain
Separating the tests for the two packages properly would be a lot of work, so that is not an option for me.
Decision: do not test a vizro-ai pycafe link, that remains manual
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":