Adding start_at and end_at to :tagged_with #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect ! Can you rebase ? |
|
Done! |
|
Tests are failing in Postgresql. (Ignore the Sqlite3 error, i'm working on it) |
|
@felipeclopes Can you rebase ? the sqlite bug was fixed. It will be great if you add and example in the Wiki. |
|
bump |
|
bump |
|
Sorry . I will merge tomorrow |
seuros
added a commit
that referenced
this pull request
Jun 17, 2014
Adding start_at and end_at to :tagged_with
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
Adding start_at and end_at to :tagged_with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding start_at and end_at to the tagged_with method.
This can be used to boost performance on queries where the taggings table is too big, like in the scenario I had to use.
It reduces drastically the amount of rows that the database have to go through, when using a good criteria.