Add support to Rails 7.1 #1110
Add support to Rails 7.1 #1110
Conversation
aovertus
force-pushed
the
support_rails_7-1
branch
from
fa22fd1 to
eba629c
Compare
|
@sampatbadhe @mbleigh what's the status on getting this merged? |
|
We've been running ActsAsTaggableOn with edge rails (updated to latest commit every week) for months without issue, now that edge rails is tagged at 7.1 our bundle install is breaking. Be great to have this merged in. Follow up question, is the less than runtime dependency really required? Instead only checking the greater & equal to 6.0 condition? At very least consider changing it to something a bit more inclusive like '<= 7'. |
acts-as-taggable-on.gemspec
Outdated
| @@ -22,7 +22,7 @@ Gem::Specification.new do |gem| | |||
| gem.post_install_message = File.read('UPGRADING.md') | |||
| end | |||
|
|
|||
| gem.add_runtime_dependency 'activerecord', '>= 6.0', '< 7.1' | |||
| gem.add_runtime_dependency 'activerecord', '>= 6.0', '< 7.2' | |||
There was a problem hiding this comment.
Consider completely removing the less than condition in our runtime dependency.
| gem.add_runtime_dependency 'activerecord', '>= 6.0', '< 7.2' | |
| gem.add_runtime_dependency 'activerecord', '>= 6.0' |
Further, consider using the Appraisal's gem to test compatibility with multiple versions of rails, including edge rails. A good example of this is the ActsAsTenant gem: https://github.com/ErwinM/acts_as_tenant/blob/master/Appraisals
There was a problem hiding this comment.
I've not check Appraisal yet but keep in mind that acts_as_taggable rely on ActiveRecord not Rails.
If I remember properly acts as tenant provide extension to more than just ActiveRecord and therefor requires Rails as a dependency not just one module
There was a problem hiding this comment.
AFAIK Appraisal gem should work with any set of dependencies - rails just happens to be the most common use case. Maybe not needed here, but if there are concerns around which run time dependencies to support, the gem can different versions as different appraisal's to run the specs against.
CHANGELOG.md
Outdated
| * Features | ||
| * [@glampr Add support for prefix and suffix searches alongside previously supported containment (wildcard) searches](https://github.com/mbleigh/acts-as-taggable-on/pull/1082) | ||
| * [@donquxiote Add support for horizontally sharded databases](https://github.com/mbleigh/acts-as-taggable-on/pull/1079) | ||
| * [aovertus Add support for Rails 7.1](https://github.com/mbleigh/acts-as-taggable-on/pull/1110) |
There was a problem hiding this comment.
| * [aovertus Add support for Rails 7.1](https://github.com/mbleigh/acts-as-taggable-on/pull/1110) | |
| * [aovertus Add support for Rails 7.1 and Edge Rails by removing the less than (forward looking) runtime dependency check for current and future activerecord versions.](https://github.com/mbleigh/acts-as-taggable-on/pull/1110) |
aovertus
force-pushed
the
support_rails_7-1
branch
from
eba629c to
3f95e06
Compare
…until next major is released
aovertus
force-pushed
the
support_rails_7-1
branch
from
3f95e06 to
cc9992b
Compare
| * Features | ||
| * [@glampr Add support for prefix and suffix searches alongside previously supported containment (wildcard) searches](https://github.com/mbleigh/acts-as-taggable-on/pull/1082) | ||
| * [@donquxiote Add support for horizontally sharded databases](https://github.com/mbleigh/acts-as-taggable-on/pull/1079) | ||
| * [aovertus Remove restriction around ActiveRecord 7.x versions allowing support until next major is released](https://github.com/mbleigh/acts-as-taggable-on/pull/1110) |
There was a problem hiding this comment.
@tvongaza does this make sense ? I think we should not allow ActiveRecord 8 as we don't know which breaking changes will comes with it ?
There was a problem hiding this comment.
Agreed, can do < 8 for now. Let's get this merged if possible please.
|
@seuros Any chance of doing a minor gem release to allow this gem to work with rails 7.1 & beyond? |
|
Hi there! any news? |
|
OK i will now |
|
Thank you! |
Update
activerecordrequirements to support Rails 7.1