Bugfix for use of old layer definition in 'fit' function #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have multiple layers in the layer description (e.g.:
Bugfix for old method of selecting layers
|
For others who encounter the same error: You can solve this as well by using This should be recommended, since the old usage (extraction of the layer numbers from the name string) is deprecated and will be removed in the future. |
|
Is there a notebook where this is used that also shows the deprecation warning? That may be useful. |
|
The Pratt County example hits the deprecation warning in the first cell of step 6. And at the same time you see the error that I encountered and want to fix with the proposed change:
|
|
Looks good. Thanks for submitting! |
mbakker7
added a commit
that referenced
this pull request
Mar 12, 2025
Some bug fixes and minor improvements: * Add inhomogeneity name to crosssection plot (1D inhom) (#90) * Added 'names' in plotting of inhom * Bugfix for old method of selecting layers (#92) * Specify step for Jacobian (#95) --------- Co-authored-by: Davíd Brakenhoff <d.brakenhoff@artesia-water.nl> Co-authored-by: Mattijs Borst <41747007+MattBrst@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the code:
ca.set_parameter(name="kaq0_2", initial=10), and the original code extracted the numbers 0 and 2 as layer numbers, but these were strings instead of integers.Fixed with this commit.