Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.7.0: Adding cross-sections to TTim #86

Merged
merged 115 commits into from
Dec 20, 2024
Merged

Release v0.7.0: Adding cross-sections to TTim #86

merged 115 commits into from
Dec 20, 2024

Conversation

dbrakenhoff
Copy link
Collaborator

@dbrakenhoff dbrakenhoff commented Dec 20, 2024

New Features:

Examples

  • Two new How-To notebooks (cross-sections and fluctuating head boundaries).
  • A calibration of aquifer parameters in a cross-section model with a tidal river (for those familiar with WATEX).

Other improvements

dbrakenhoff and others added 30 commits September 27, 2024 19:02
- add extra CI step to add coverage for numba bessel
- is exactly equal on my pc, but has extra decimal in complex part on gh actions, diff is 5e-17 so that should be okay.
- cannot set array item with array, must be scalar (zminzbar and omega)
- could not unify float/int and complex for term1 and term2
- use builtin types to initialize arrays
- use super()
- label methods abstractmethods
- add ax to plot
* Make PlotTim a submodule of the Model class.
- add topview method (the old .plot()
- add xsection()
- add head_along_line(), the old xsection
- move to object oriented plotting using ax instead of plt

* add ax argument to Element.plot

* do not inherit from PlotTim but initialize as submodule
- add .plots submodule
- reinstate ml.plot using new module
- deprecate xsection

* modify plotting methods for elements

* update metadata in pyproject.toml

* ruff

* deprecate ml.contour, use ml.plots.contour everywhere

* update notebooks, docs

* improve plotting some more
- somehow search and replace wasnt working in vscode, now using right methods everywhere
- improve legend in head_along_line
- add ax to element plot methods

* rename util.py to plots.py
make t 1d array

* Some small changes

Will do some others as well

* fixed labels in contour

* minor changes to notebooks

Some more will follow

* ruff

* some more notebooks formatted

* added grid

* ruff on notebooks

---------

Co-authored-by: Mark Bakker <markbak@gmail.com>
- first linesink1d commit
- add LineSink1DBase, DischargeLineSink1D, LineSink1D and HeadLineSink1D
- add example notebook with comparison to analytical solutions. Only single aquifers for now.
- add 1d leaky wall
- add example in notebook
- add 1d leaky wall
- add example in notebook
add tests for numba bessel functions
* example with variable entry resistance

required one fix in wellborestorage equation

* ruff

* added units to parameters of example

* ruff
@dbrakenhoff dbrakenhoff requested a review from mbakker7 December 20, 2024 10:45
@dbrakenhoff
Copy link
Collaborator Author

@mbakker7, should we make a new release or leave the cross-section stuff on develop for a while? I forgot what we discussed...

Copy link
Owner

@mbakker7 mbakker7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of work went into this new development. I think it is ready to go!

@dbrakenhoff dbrakenhoff merged commit 9bd9c51 into master Dec 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants