-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.7.0: Adding cross-sections to TTim #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add extra CI step to add coverage for numba bessel
- is exactly equal on my pc, but has extra decimal in complex part on gh actions, diff is 5e-17 so that should be okay.
- use builtin types to initialize arrays - use super()
- label methods abstractmethods - add ax to plot
* Make PlotTim a submodule of the Model class. - add topview method (the old .plot() - add xsection() - add head_along_line(), the old xsection - move to object oriented plotting using ax instead of plt * add ax argument to Element.plot * do not inherit from PlotTim but initialize as submodule - add .plots submodule - reinstate ml.plot using new module - deprecate xsection * modify plotting methods for elements * update metadata in pyproject.toml * ruff * deprecate ml.contour, use ml.plots.contour everywhere * update notebooks, docs * improve plotting some more - somehow search and replace wasnt working in vscode, now using right methods everywhere - improve legend in head_along_line - add ax to element plot methods * rename util.py to plots.py make t 1d array * Some small changes Will do some others as well * fixed labels in contour * minor changes to notebooks Some more will follow * ruff * some more notebooks formatted * added grid * ruff on notebooks --------- Co-authored-by: Mark Bakker <markbak@gmail.com>
- first linesink1d commit - add LineSink1DBase, DischargeLineSink1D, LineSink1D and HeadLineSink1D - add example notebook with comparison to analytical solutions. Only single aquifers for now.
Minor improvements to code
- add 1d leaky wall - add example in notebook
- add 1d leaky wall - add example in notebook
add tests for numba bessel functions
* example with variable entry resistance required one fix in wellborestorage equation * ruff * added units to parameters of example * ruff
…continuity of flow
…l river with two observation wells
but need to fix multi-layer inhoms in calibrate
Simplified and updated
took out well resistance as there is no measurement inside the well
Add cross-section models
@mbakker7, should we make a new release or leave the cross-section stuff on develop for a while? I forgot what we discussed... |
mbakker7
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of work went into this new development. I think it is ready to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features:
Examples
Other improvements