Manual side feature #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should not commit |
|
Done! |
|
Thank you. It is 1:15am here. I'll review tomorrow when I get time. |
|
Ok! Thank you very much! I'll be waiting for news! See you! |
|
Hi there |
mazid1
requested changes
Feb 11, 2022
| @@ -0,0 +1,15 @@ | |||
| /*! ***************************************************************************** | |||
There was a problem hiding this comment.
Could you please remove this entire node_modules folder from the PR.
|
has this been merged? |
|
@soniclvr811 I could not merge it because of so many conflicts and the entire node_modules was committed. Anyway, this pr is actually too old to resolve conflicts. I think, it will be easier to re-implement this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new feature: you can set manualSide property true and then set the property leftSide (in the child component) true or false in order to select the position of the children. That feature has priority above the alternateSide property. With this feature you can select the side of each child.
I also upload the /dist folder because previously I tried to implement the library myself but i couldn't do it succesfully.
Can you approve the pull request?