Provide an accurate return type for Injected and SyncInjected #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Specify return type for
Injected
andSyncInjected
Why
Previously, the return type was
Any
. It was therefore necessary to specify the type of every injected argument like soFor developers who rely on a static type checker that infers argument types by default values (e.g. PyRight), this can now be simplified to
without loss of type information.
As far as I can tell, mypy still doesn't infer argument types like PyRight does (see python/mypy#3090). I have therefore left the code examples as-is.