Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Starting with apt 1.6, https support has moved into the main package … #7801

Merged
merged 4 commits into from
Jul 8, 2020
Merged

Starting with apt 1.6, https support has moved into the main package … #7801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b72f2c5
Starting with apt 1.6, https support has moved into the main package …
heini Jul 8, 2020
45f9f12
Add changelog entry.
heini Jul 8, 2020
6790fe7
Add changes as requested.
heini Jul 8, 2020
2362441
Merge remote-tracking branch 'orig/develop' into debian_packages
heini Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions INSTALL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,17 @@ Synapse via https://packages.matrix.org/debian/. They are available for Debian

```
sudo apt install -y lsb-release wget apt-transport-https
```

for Debian/Ubuntu versions shipping `apt` < 1.6 (Debian < 10 / Ubuntu < 18.04), or

```
sudo apt install -y lsb-release wget
```

for Debian 10 / Ubuntu 18.04 and newer, followed by

```
Comment on lines +262 to +272
Copy link
Member

@richvdh richvdh Jul 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm. I am unconvinced by this.

My concern is that it makes things much more complicated for users to understand what to do. It used to be a single set of commands that people could follow; now they have to read carefully to understand exactly which commands they have to run.

People are terrible at reading.

At the very least, I'd prefer sudo apt install -y apt-transport-https to be an additional step which you have to apply for older systems, but why is it a problem if the apt-transport-https package is installed on distros where it is a dummy package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why install useless packages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I explained that. Because it's much easier to say to a user "here, follow this one set of instructions" than "check your apt version and then copy some bits from here, and some other bits from over there".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then he finds out it's a dummy and deinstalls it again...

Anyway, I'll reword the text...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then he finds out it's a dummy and deinstalls it again...

well, that's no problem. If the user is smart enough to do that, they are welcome to.

I do see your point, I just think https://github.com/matrix-org/synapse/blob/2362441544b0dd510cae9321c34e76aca3ad9965/INSTALL.md#matrixorg-packages is an order of magnitude harder to understand than https://github.com/matrix-org/synapse/blob/91a7c5ff6d3a4bc30d61da96e4923d391c6d2ed9/INSTALL.md#matrixorg-packages, and people already find our installation instructions scary.

I think I'm going to revert this for now; if you'd like to suggest improvements, feel free to make a separate PR (or better yet, join #synapse-dev:matrix.org to discuss).

sudo wget -O /usr/share/keyrings/matrix-org-archive-keyring.gpg https://packages.matrix.org/debian/matrix-org-archive-keyring.gpg
echo "deb [signed-by=/usr/share/keyrings/matrix-org-archive-keyring.gpg] https://packages.matrix.org/debian/ $(lsb_release -cs) main" |
sudo tee /etc/apt/sources.list.d/matrix-org.list
Expand Down
1 change: 1 addition & 0 deletions changelog.d/7801.doc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Change the installation documentation regarding the `apt-transport-https` package, which is no longer needed on Debian 10/Ubuntu 18.04 and newer.