This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom well-known #13035
Add custom well-known #13035
Changes from 9 commits
03b6cfb
68ac6b3
3375928
177f9f2
10e563d
16b0431
3b9b351
e87b7b3
c3356bf
36e6adf
068d792
3c4e641
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised these tests pass as written.
default_config
; fields that aren't mentioned don't get changeddefault_config
(see also - Add custom well-known #13035 (comment))There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh. We only actually serve well-known if a public_baseurl is explicitly set:
synapse/synapse/config/server.py
Lines 273 to 289 in e87b7b3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these tests add much compared to
test_client_well_known_no_public_baseurl
(since that is the condition). Can you remove these please?