Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Remove get_destination_retry_timings cache
Browse files Browse the repository at this point in the history
Currently we rely on the master to invalidate this cache promptly.
However, after having moved most federation endpoints off of master this
no longer happens, causing outbound fedeariont to get blackholed.

Fixes #3798
  • Loading branch information
erikjohnston committed Sep 19, 2018
1 parent 05b9937 commit b9158ac
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions synapse/storage/transactions.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ def delivered_txn(self, transaction_id, destination, code, response_dict):
"""
pass

@cached(max_entries=10000)
def get_destination_retry_timings(self, destination):
"""Gets the current retry timings (if any) for a given destination.
Expand Down Expand Up @@ -212,10 +211,6 @@ def _set_destination_retry_timings(self, txn, destination,
retry_last_ts, retry_interval):
self.database_engine.lock_table(txn, "destinations")

self._invalidate_cache_and_stream(
txn, self.get_destination_retry_timings, (destination,)
)

# We need to be careful here as the data may have changed from under us
# due to a worker setting the timings.

Expand Down

0 comments on commit b9158ac

Please sign in to comment.