Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI currently failing with broken links #1336

Closed
turt2live opened this issue Nov 14, 2022 · 2 comments · Fixed by #1338 or #1346
Closed

CI currently failing with broken links #1336

turt2live opened this issue Nov 14, 2022 · 2 comments · Fixed by #1338 or #1346
Assignees
@richvdh
Labels
A-Tools Related to the process and tools for building the spec meta Something that is not a spec change/request and is not related to the build tools release-blocker Blocks the next release from happening

Comments

@turt2live
Copy link
Member

eg https://github.com/matrix-org/matrix-spec/actions/runs/3423504915/jobs/5702191261
@turt2live turt2live added A-Tools Related to the process and tools for building the spec meta Something that is not a spec change/request and is not related to the build tools release-blocker Blocks the next release from happening labels Nov 14, 2022
@richvdh
Copy link
Member

richvdh commented Nov 14, 2022

that seems to be because the CI for main sticks an /unstable on the front of all the links, which I think is easily accounted for in the link checker

@richvdh richvdh self-assigned this Nov 14, 2022
@turt2live turt2live mentioned this issue Nov 14, 2022
Closed
12 tasks
richvdh added a commit that referenced this issue Nov 15, 2022
@richvdh
Unpack spec into right place for htmltest
5600954 
Hopefully, fixes #1336
@richvdh richvdh mentioned this issue Nov 15, 2022
Merged
richvdh added a commit that referenced this issue Nov 15, 2022
@richvdh
Unpack spec into right place for htmltest (#1338)
3c9139b 
Hopefully, fixes #1336
@richvdh richvdh reopened this Nov 16, 2022
@richvdh
Copy link
Member

richvdh commented Nov 16, 2022

There are some actual broken links; Hugo seems to be generating links to RSS with too many /unstables in the URL:

<link rel="alternate" type="application/rss&#43;xml" href="/unstable/unstable/index.xml">

richvdh added a commit that referenced this issue Nov 16, 2022
@richvdh
Disable RSS for spec
92c762f 
This should really fix #1336
@richvdh richvdh mentioned this issue Nov 16, 2022
Merged
richvdh added a commit that referenced this issue Nov 16, 2022
@richvdh
Disable RSS for spec (#1346)
f0246a5 
This should really fix #1336
clokep pushed a commit to clokep/matrix-spec that referenced this issue May 3, 2023
@richvdh @clokep
Unpack spec into right place for htmltest (matrix-org#1338)
7516acf 
Hopefully, fixes matrix-org#1336
clokep pushed a commit to clokep/matrix-spec that referenced this issue May 3, 2023
@richvdh @clokep
Disable RSS for spec (matrix-org#1346)
a46aed7 
This should really fix matrix-org#1336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richvdh richvdh

Labels
A-Tools Related to the process and tools for building the spec meta Something that is not a spec change/request and is not related to the build tools release-blocker Blocks the next release from happening
Projects
None yet
Milestone
No milestone
2 participants
@turt2live @richvdh