Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-server spec gets processed for Markdown twice #1204

Closed
turt2live opened this issue Aug 9, 2022 · 1 comment · Fixed by #1970
Closed

Client-server spec gets processed for Markdown twice #1204

turt2live opened this issue Aug 9, 2022 · 1 comment · Fixed by #1970
Labels
A-Tools Related to the process and tools for building the spec

Comments

@turt2live
Copy link
Member

The other specs do not appear to be affected by this for some reason. I haven't looked into why or what might be causing this.

The effect of this bug is that shortcodes which would normally be inline end up as blocks. For example, stick this somewhere in the prose:

{{< added-in v="1.4" >}} This is meant to have an "Added In" before it, inline. Not as a block element above this text.

The angle brackets mean to handle it as a literal (% means process it), but regardless it ends up spitting out HTML into the interstitial document, which then gets a second markdown process over it and converts the HTML to a block element. Ideally we stick the HTML from the shortcodes into a rendered markdown document so the formatting is preserved.

@turt2live turt2live added the A-Tools Related to the process and tools for building the spec label Aug 9, 2022
richvdh added a commit that referenced this issue Aug 9, 2022
... because that fixes everything. Or at least, #1204.
@richvdh
Copy link
Member

richvdh commented Aug 9, 2022

I think #1205 fixes this?

richvdh added a commit that referenced this issue Aug 9, 2022
... because that fixes everything. Or at least, #1204.
richvdh added a commit that referenced this issue Aug 10, 2022
... because that fixes everything. Or at least, #1204.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tools Related to the process and tools for building the spec
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants