-
-
Notifications
You must be signed in to change notification settings - Fork 827
Display and send votes in polls #7158
Display and send votes in polls #7158
Conversation
@SimonBrandner we're labelling polls stuff as T-Task for now, so it doesn't appear in the release notes until it's ready to use. |
Ah, sorry for misusing the label, thanks for letting me know |
Actually I think it's probably me misusing the labels, but I guess not calling it a feature when it's hidden behind a labs flag is sort-of legit. |
I wholeheartedly disagree with the verdict of this poll, but it's a lovely render! |
I actually had to re-do the screenshot because I accidentally got the wrong answer first time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brill :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fine - just a few human linter things that we really should put into the lint rules.
Co-authored-by: Travis Ralston <travpc@gmail.com>
Co-authored-by: Travis Ralston <travpc@gmail.com>
Co-authored-by: Travis Ralston <travpc@gmail.com>
Co-authored-by: Travis Ralston <travpc@gmail.com>
Co-authored-by: Travis Ralston <travpc@gmail.com>
I have completed all the requested changes, thanks. |
@turt2live this is ready for you to re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is the first draft of votes being sent and displayed in polls.
Later pull requests will fix some issues:
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://6197752cb934fbbc06eaaa12--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.