Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add PassphraseConfirmField component for registration and password recovery screens #7044

Merged

Conversation

psrpinto
Copy link
Contributor

@psrpinto psrpinto commented Oct 27, 2021

Adds an PassphraseConfirmField component for the registration and password recovery screens. This is the second PR in a series of three, started with #7006, which introduced an EmailField component.

The third and last PR in the series will use these components to improve the password recovery screen.

There are no user-visible changes.
Type: [task]


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://618c028b1dcd79009c592e63--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Signed-off-by: Paulo Pinto <paulo.pinto@automattic.com>
Signed-off-by: Paulo Pinto <paulo.pinto@automattic.com>
Signed-off-by: Paulo Pinto <paulo.pinto@automattic.com>
Signed-off-by: Paulo Pinto <paulo.pinto@automattic.com>
@psrpinto psrpinto requested a review from a team as a code owner October 27, 2021 14:45
@psrpinto
Copy link
Contributor Author

Tagging @t3chguy since they reviewed the previous PR in the series, and I don't have permissions to request reviews.

@t3chguy t3chguy requested review from t3chguy and removed request for a team October 29, 2021 08:34
@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 29, 2021
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Signed-off-by: Paulo Pinto <paulo.pinto@automattic.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants