This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add possibility to delay rageshake persistence in app startup #5767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if the app takes a moment to set up persistence, this will still capture any logs before persistence happened.
turt2live
added a commit
to element-hq/element-web
that referenced
this pull request
Mar 16, 2021
This also delays the persistence until later in the app startup - this is fine for the reasons listed on the partner PR: matrix-org/matrix-react-sdk#5767 Fixes #16694
dbkr
approved these changes
Mar 18, 2021
alangecker
added a commit
to zirkuszelt/frontend
that referenced
this pull request
Mar 19, 2021
A PR got already merged in our element-web base, but the partner PR in matrix-react-sdk was still missing. matrix-org/matrix-react-sdk#5767 this is to be reverted as soon as we do the next rebase of element-web. consider to rebase to a release instead of 'develop' next time :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the app takes a moment to set up persistence, this will still capture any logs before persistence happened.
For element-hq/element-web#16697