This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Convert cross-signing feature flag to setting #4416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended as a temporary measure until we're comfortable with removing the flag entirely.
turt2live
commented
Apr 15, 2020
|
@matrix-org/product please review this for the theory of bringing cross-signing out of labs and into the real world. |
It's not perfect, but we're at least okay with it.
nadonomy
approved these changes
Apr 16, 2020
|
@jryans this should be ready for review. I've tested it and it enables it by default for a new test account, which managed to cross-sign and verify the real me. |
There's no buttons in the field.
The continue button is probably no-oping due to being disabled.
|
(the nightmare of test fixing has been approved oob) |
jryans
added a commit
to element-hq/element-web
that referenced
this pull request
May 5, 2020
The cross-signing feature flag was changed to a setting, so these values are outdated and can be removed. See also matrix-org/matrix-react-sdk#4416
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as a temporary measure until we're comfortable with removing the flag entirely (something like #4417).