This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix vector-im/riot-web#6523 Emoji rendering destroys paragraphs #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regression was probably introduced in 4f4441f and is caused by the fact that the variable `isHtml` conflates two different meanings: - The event contains an HTML message - The event message is displayed using HTML This is an important difference. Plain text messages that contain emojies are rendered with an HTML string and thus have to be sanitized etc. But they must not use the MarkDown CSS styles for HTML messages. The MarkDown CSS styles include `whitespace: normal` because HTML events use `<br/>`-tags for line breaks. Plain text messages with emojies obviously don't use `<br/>`-tags, so these styles must not be applied. Signed-off-by: Jonas Schürmann <jonasschuermann@aol.de>
MazeChaZer
force-pushed
the
fix-emoji-line-break-bug
branch
from
2e19c7d to
4a9f4ba
Compare
lukebarnard1
approved these changes
May 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regression was probably introduced in
4f4441f and is caused by the fact that
the variable
isHtmlconflates two different meanings:This is an important difference. Plain text messages that contain
emojies are rendered with an HTML string and thus have to be sanitized
etc. But they must not use the MarkDown CSS styles for HTML messages.
The MarkDown CSS styles include
whitespace: normalbecause HTML eventsuse
<br/>-tags for line breaks. Plain text messages with emojiesobviously don't use
<br/>-tags, so these styles must not be applied.Signed-off-by: Jonas Schürmann jonasschuermann@aol.de