This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add activity toggle for TAC #12413
Merged
Add activity toggle for TAC #12413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
added
the
T-Enhancement
t3chguy
reviewed
Apr 12, 2024
florianduros
suggested changes
Apr 12, 2024
src/components/views/spaces/threads-activity-centre/useUnreadThreadRooms.ts
Outdated
Show resolved
Hide resolved
src/components/views/spaces/threads-activity-centre/useUnreadThreadRooms.ts
Outdated
Show resolved
Hide resolved
src/settings/Settings.tsx
Outdated
| default: false, | ||
| invertedSettingName: "feature_hidebold", | ||
| }, | ||
| "Notifications.hidebold_tac": { |
There was a problem hiding this comment.
The name hidebold_tac is hard to understand. What bold means in TAC? Bold is the visual representation of a thread state. In our case we want to show only notifications and highlights if this settings is at true
There was a problem hiding this comment.
Yeah, I was going for consistency with the other setting, but maybe it's better to just be clear. Renamed.
florianduros
approved these changes
Apr 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes the general activity/bold toggle out of labs and adds a setting to display activity in the TAC, as we did previously.
Checklist
public/exportedsymbols have accurate TSDoc documentation.