Chrome isn't using WebKit anymore #18252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Findus23
added
the
c: Usability
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
Findus23
force-pushed
the
no-chrome-webkit
branch
from
4d8c2db to
8f8574b
Compare
|
I rebased this on 4.x-dev, so it can be merged once the tests are fixed. |
github-actions
bot
removed
the
Stale
sgiehl
added a commit
to matomo-org/plugin-CustomVariables
that referenced
this pull request
Nov 18, 2021
11 tasks
|
I have updated the tests. Should be good to review now |
sgiehl
force-pushed
the
no-chrome-webkit
branch
from
c7c06d5 to
56d2c87
Compare
sgiehl
added a commit
to matomo-org/plugin-CustomVariables
that referenced
this pull request
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome hasn't been using WebKit since 2013, so I think we can now update that info text and not confuse users.
Tests will be fixed separately as unfortunately a search/replace strips trailing whitespace.
Review