Change TaskDelayBetweenEachVal in bridge based on mempool #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POS-282 Change TaskDelayBetweenEachVal in bridge based on mempool
Basically determine how filled is mempool and change the value of delay accordingly. |
Codecov Report
@@ Coverage Diff @@
## krishna/mempool-test #816 +/- ##
=====================================================
Coverage 72.73% 72.73%
=====================================================
Files 49 49
Lines 3517 3517
=====================================================
Hits 2558 2558
Misses 730 730
Partials 229 229 Continue to review full report at Codecov.
|
ssandeep
reviewed
Apr 13, 2022
ssandeep
reviewed
Apr 14, 2022
manav2401
added a commit
that referenced
this pull request
Apr 27, 2022
* mempool check test * add: check state-sync tx in mempool before broadcast, generalise old tx function for all processors * add: unit test for state-sync tx broadcast by checking against mempool * fix: typo * Revert "mempool check test" This reverts commit 3d93d20. * fix: minor fixes * fix: invalid checkpoint message * fix: handle error, update error message * fix: consider event type in isOldTx generic function * update retry delay for state sync events * add: modularise bridge event types * bridge/setu: change TaskDelayBetweenEachVal in bridge based on mempool (#816) * add: calculate task delay bases on mempool count * minor refactor Co-authored-by: Krishna Upadhyaya <krishnau1604@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional delay by bridge in sending txs to heimdall based on the state of the mempool.
It will increase the delay factor for every 1000 unconfirmed txns in mempool.
For example if the current default delay is 12 Seconds
Then for upto 1000 txns it will stay as 12 sec
For 1000-2000 It will be 24 seconds
For 2000-3000 it will be 36 seconds
Basically for every 1000 txns it will increase the factor by 1.