Added MaxStateSyncDataLength with hardfork #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## arpit/pos-258 #792 +/- ##
=================================================
- Coverage 72.89% 72.73% -0.16%
=================================================
Files 49 49
Lines 3508 3517 +9
=================================================
+ Hits 2557 2558 +1
- Misses 723 730 +7
- Partials 228 229 +1
Continue to review full report at Codecov.
|
vcastellm
approved these changes
Mar 15, 2022
In https://github.com/maticnetwork/heimdall/pull/791/files |
jdkanani
reviewed
Mar 15, 2022
jdkanani
reviewed
Mar 15, 2022
jdkanani
reviewed
Mar 15, 2022
jdkanani
reviewed
Mar 15, 2022
vcastellm
reviewed
Mar 15, 2022
ssandeep
reviewed
Mar 15, 2022
0xKrishna
requested review from
temaniarpit27 and
ssandeep
and removed request for
vcastellm
anilcse
reviewed
Mar 16, 2022
anilcse
approved these changes
Mar 16, 2022
| return 0 | ||
| } | ||
|
|
||
| return response.Height |
There was a problem hiding this comment.
Just wanted to double confirm if this returns latest height. Are we missing any checks around this?
There was a problem hiding this comment.
Yes, Using this API for the height
https://heimdall.api.matic.network/checkpoints/count
jdkanani
approved these changes
Mar 16, 2022
temaniarpit27
added a commit
that referenced
this pull request
Mar 16, 2022
* add begin blocker * height moved to file * 50k to 100k * remove check * Revert "remove check" This reverts commit d2a4f13. * review comments * minor changes * Update mumbai.toml * Added MaxStateSyncDataLength with hardfork (#792) * Added MaxStateSyncDataLength with hardfork * formatted if-else * update variable name * Added block check in bridge * fix height issue in clerk cli and rest Co-authored-by: Krishna Upadhyaya <KRISHNAU1604@GMAIL.COM>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.