Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override spans 4034-4083 on mainnet #786

Merged

Conversation

petejkim
Copy link
Contributor

@petejkim petejkim commented Mar 11, 2022

Based on:

Changes:

  • Load and parse JSON only once
  • Optimize span look up
  • Override spans only on chain ID heimdall-137

@petejkim petejkim changed the base branch from master to anil/fix_halt_height March 11, 2022 22:00
@petejkim petejkim changed the base branch from anil/fix_halt_height to master March 11, 2022 22:03
@petejkim petejkim force-pushed the petejkim/span-overrides branch from c4d14c7 to 796e0b3 Compare March 11, 2022 22:03
@petejkim petejkim force-pushed the petejkim/span-overrides branch 3 times, most recently from d035a75 to 1684344 Compare March 11, 2022 22:28
@anilcse anilcse changed the base branch from master to anil/fix_halt_height March 12, 2022 02:27
@petejkim petejkim force-pushed the petejkim/span-overrides branch from 1684344 to 854c053 Compare March 12, 2022 02:53
@petejkim petejkim changed the title Override spans 4034-4053 on mainnet Override spans 4034-4083 on mainnet Mar 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2022

Codecov Report

Merging #786 (aefabc0) into anil/fix_halt_height (99e6046) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           anil/fix_halt_height     #786   +/-   ##
=====================================================
  Coverage                 72.89%   72.89%           
=====================================================
  Files                        49       49           
  Lines                      3508     3508           
=====================================================
  Hits                       2557     2557           
  Misses                      723      723           
  Partials                    228      228           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e6046...aefabc0. Read the comment docs.

@petejkim petejkim force-pushed the petejkim/span-overrides branch from 854c053 to aefabc0 Compare March 12, 2022 03:07
@anilcse anilcse merged commit 8f7a714 into maticnetwork:anil/fix_halt_height Mar 12, 2022
anilcse added a commit that referenced this pull request Mar 12, 2022
* Fix halt-height issue

* fix halt-height and restart

* feat: add rollback feat (#784)

* Override spans 4034-4083 on mainnet (#786)

* Backport bor's tmp-span-hotfix to heimdall

maticnetwork/bor@10c4e89

* fix: serve hardcoded spans if exists on mainnet

Co-authored-by: chub <chub@users.noreply.github.com>

Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com>
Co-authored-by: Pete Kim <petejkim@users.noreply.github.com>
Co-authored-by: chub <chub@users.noreply.github.com>
temaniarpit27 added a commit that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants