Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chg: change rootchain submitHeaderBlock interface (Mainnet v1 changes) #538

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

jdkanani
Copy link
Contributor

@jdkanani jdkanani commented Feb 5, 2021

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 5, 2021

Codecov Report

Merging #538 (1a29222) into mainnet-backport (1d8aca3) will decrease coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           mainnet-backport     #538      +/-   ##
====================================================
- Coverage             73.46%   72.99%   -0.47%     
====================================================
  Files                    49       49              
  Lines                  3946     3411     -535     
====================================================
- Hits                   2899     2490     -409     
+ Misses                  828      703     -125     
+ Partials                219      218       -1     
Impacted Files Coverage Δ
clerk/genesis.go 60.00% <0.00%> (-17.78%) ⬇️
checkpoint/module.go 31.64% <0.00%> (-5.50%) ⬇️
staking/genesis.go 68.42% <0.00%> (-5.50%) ⬇️
staking/module.go 41.07% <0.00%> (-4.61%) ⬇️
app/utils.go 50.00% <0.00%> (-4.39%) ⬇️
staking/keeper.go 62.04% <0.00%> (-4.13%) ⬇️
topup/keeper.go 78.87% <0.00%> (-3.89%) ⬇️
clerk/keeper.go 78.37% <0.00%> (-3.85%) ⬇️
checkpoint/keeper.go 79.81% <0.00%> (-3.39%) ⬇️
staking/querier.go 55.43% <0.00%> (-3.39%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8aca3...1a29222. Read the comment docs.

Copy link

@imyourm8 imyourm8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdkanani jdkanani merged commit 66c0e82 into mainnet-backport Mar 10, 2021
@jdkanani jdkanani deleted the jdkanani/change-checkpoint-sig-mainnet branch March 10, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants