Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing unnecesary log when django-ninja is not installed #53

Conversation

maticardenas
Copy link
Owner

The optional import of django-ninja is there because it's not mandatory to have it installed to have the package, as one could use it with DRF. However, it's not necessary to have a log entry informing this, given this is already logged when attempting to create an instance of OpenAPINinjaClient.

This PR handles the previous described situation, by removing the log entry.

@maticardenas maticardenas added the enhancement New feature or request label Dec 12, 2024
@maticardenas maticardenas self-assigned this Dec 12, 2024
@maticardenas maticardenas linked an issue Dec 12, 2024 that may be closed by this pull request
@maticardenas maticardenas merged commit 705cfab into master Dec 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging.info("Django-Ninja is not installed.") uses the root logger
1 participant