Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

feat(checkbox): Adds a value property to the component and foundation. #492

Merged
merged 1 commit into from
Apr 10, 2017
Merged

feat(checkbox): Adds a value property to the component and foundation. #492

merged 1 commit into from
Apr 10, 2017

Conversation

shyndman
Copy link

@shyndman shyndman commented Apr 8, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 8, 2017

Codecov Report

Merging #492 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
+ Coverage   99.17%   99.17%   +<.01%     
==========================================
  Files          40       40              
  Lines        2050     2058       +8     
  Branches      261      261              
==========================================
+ Hits         2033     2041       +8     
  Misses         17       17
Impacted Files Coverage Δ
packages/mdc-checkbox/foundation.js 100% <100%> (ø) ⬆️
packages/mdc-checkbox/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f136c...0481ba9. Read the comment docs.

Copy link
Contributor

@traviskaufman traviskaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎 💯 Thank you! Just one doc nit.

@@ -139,6 +139,11 @@ underlying checkbox element.
Boolean. Returns whether or not the checkbox is disabled. Setting this property will update the
underlying checkbox element.

##### MDCRadio.value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean MDCCheckbox.value here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@traviskaufman traviskaufman merged commit ff772ad into material-components:master Apr 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants