Combine API request spec assertions #31970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prep for adding a truly comical amount of "is this a json response" checks (see #31749 (comment)), this is a once over on the api request specs looking for places to consolidate multiple request/response cycles.
Reduces factory creation from ~3050 to ~2900, specs run slightly faster (just over a minute to just under a minute pretty reliably for api req specs only locally).
I tried to minimize any style/formatting stuff and keep it to just combining things. Will probably do the json response additions, and then do another pass to address any truly weird readability/formatting things in the aftermath of the various changes.