Updated default binds #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsCompetitiveMode was updated to include Casual, but Demo Support still makes the same old assumptions. So, fix the strings to properly reflect how ds_enable works, and add a popular community request to only record true competitive matches (either competitive matchmaking or community tournaments). The fact that there isn't a setting at the moment which excludes Casual (which uses mp_tournament) is a cited reason for people still using P-REC. Some files also need to be updated for this. A new localization string #TF_DemoSupport_Matchmaking should be added "Auto-record matchmaking matches" user_default.scr needs to be updated for the ds_enable list option "1" should be "#TF_DemoSupport_Matchmaking" and a new option "4" should be "#TF_DemoSupport_Comp" also add ds_rounds_only to filter out the filler parts of rounds to record only active round play
sometimes, attackers are not defined. this NULL check has precedent in other filters, so we do it here too to make sure we don't crash in the case of incorrect take damage info. can happen with some custom stuff. also, fix the known case of a null attacker for the passtime ball.
SoundDuration does not work on dedicated servers For one, SV_GetSoundDuration is not implemented for them. Two, sounds are not shipped on dedicated servers. So, it's pointless and misleading to query the sound duration on servers. Save a little bit by letting the sound emit function skip trying to query for these sounds. I replaced sound durations as needed with a sensible sound duration for different cooldowns and such, so sounds do not spam anymore, thinks run properly, etc.
may need an adjustment for sticky traps (5s) / air dets only -- will playtest
…tercoms in detail about what size it should be and discussed various resolutions it should be based on and mastercoms chose the resolution that would make the overheal the largest, anyways this commit just divides the number by 2
* F3 no longer binds to "show_matchmaking" which no longer exists * F3 is now binded to "toggleconsole". "`" as the default bind is a key that doesn't work with other keyboards (ES for example), and it can't be used in the main menu * remove: "+moveup""+movedown""+lookup""+lookdown""centerview""+strafe""+klook" since they are pointless. "+mlook" is already commented * remove bind "e" "dropitem" because it is overriden and doesn't work anyways * add bind "F4" "player_ready_toggle" to show it properly in the options menu * remove bind "PAUSE" "pause" because it is pointless. This could be restored however due to usage in comp matches? but ehh * remove bind "F1" "+showroundinfo" because it doesn't exist
reduced the health size of the bonus overheal
|
Integrated some of these changes in the above referenced commit. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation
Screenshots
Checklist
tc2-modbranch.Testing Checklist