🆕 feat(Cascader): support binding value for List<TItemValue> type
#2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This pull request introduces support for binding values of type List in Cascader components while refactoring generic type parameters and updating related examples and documentation. Key changes include:
- Adding a new interface ICascader<TItem, TItemValue> to define cascader behavior.
- Updating MCascader and related components to support an additional generic parameter TItemValue and handle list binding.
- Revising examples and documentation to demonstrate the new list binding functionality.
Reviewed Changes
| File | Description |
|---|---|
| src/Masa.Blazor/Components/Cascader/ICascader.cs | Introduces a new interface to support cascader binding with TItemValue. |
| src/Masa.Blazor/Components/Cascader/MCascader.razor.cs | Refactors generics and updates internal state handling to support List binding. |
| docs/... | Updates documentation and example pages to align with the new cascader binding approach. |
| src/Masa.Blazor/Components/Select/MSelect.razor.cs | Minor change regarding the method signature for OnMenuActiveChange. |
| src/Masa.Blazor/Components/Cascader/MCascader.razor | Updates markup to use new generic parameters and cascader context. |
| src/Masa.Blazor.Playground/Pages/Index.razor | Updates playground usage reflecting new binding types. |
| docs/Masa.Blazor.Docs/Examples/... | Adjusts examples to reflect changes in ItemValue and generic parameters. |
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Qinyouzeng
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2270