Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(Cron): No parameterless constructor defined #2331

Merged
merged 1 commit into from
Feb 26, 2025
Merged

🐛 fix(Cron): No parameterless constructor defined #2331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Masa.Blazor/Presets/Cron/Items/CronItemBase.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<MRadio Value="CronTypes.Period">
<LabelContent>
<div class="m-cron-period__radio-label">
@I18n.T($"$masaBlazor.cron.{nameof(CronTypes.Period).ToLower()}.{_period.ToString().ToLower()}")
@I18n.T($"$masaBlazor.cron.{nameof(CronTypes.Period).ToLower()}.{Period.ToString().ToLower()}")
</div>
</LabelContent>
</MRadio>
Expand Down
21 changes: 8 additions & 13 deletions src/Masa.Blazor/Presets/Cron/Items/CronItemBase.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@ namespace Masa.Blazor.Presets.Cron;

public partial class CronItemBase : ComponentBase
{
public CronItemBase(PeriodTypes period)
{
_period = period;
}

[Inject] protected I18n I18n { get; set; } = null!;

[Parameter] public string? Value { get; set; }
Expand All @@ -17,7 +12,7 @@ public CronItemBase(PeriodTypes period)

[Parameter] public EventCallback<CronItemModel> CronValueHasChanged { get; set; }

private readonly PeriodTypes _period;
protected PeriodTypes Period { get; init; }

protected CronTypes SelectedCronType;

Expand All @@ -39,12 +34,12 @@ public CronItemBase(PeriodTypes period)

protected override void OnInitialized()
{
if (_period != PeriodTypes.Week && _period != PeriodTypes.Year)
if (Period != PeriodTypes.Week && Period != PeriodTypes.Year)
{
I18NUnitText = I18n.T($"$masaBlazor.period.{_period}");
I18NUnitText = I18n.T($"$masaBlazor.period.{Period}");
}

switch (_period)
switch (Period)
{
case PeriodTypes.Second:
case PeriodTypes.Minute:
Expand Down Expand Up @@ -77,7 +72,7 @@ protected override void OnInitialized()
break;
}

if (_period == PeriodTypes.Week)
if (Period == PeriodTypes.Week)
{
WeekNumbers = Enum.GetValues<WeekNumbers>().ToList();
DayOfWeeks = Enum.GetValues<DayOfWeek>().ToList();
Expand Down Expand Up @@ -236,7 +231,7 @@ private async Task CalculateCronValue()
val = (1 + (int)CronItemData.SelectDayOfWeek) + "#" + CronItemData.SelectWeekNumber.ToString("d");
break;
case CronTypes.LastOfPeriod:
if (_period == PeriodTypes.Day)
if (Period == PeriodTypes.Day)
{
val = "L";
}
Expand Down Expand Up @@ -266,7 +261,7 @@ private async Task CalculateCronValue()

if (CronValueHasChanged.HasDelegate)
{
await CronValueHasChanged.InvokeAsync(new CronItemModel() { Period = _period, CronValue = val });
await CronValueHasChanged.InvokeAsync(new CronItemModel() { Period = Period, CronValue = val });
}
}

Expand Down Expand Up @@ -328,7 +323,7 @@ private void InitValue()
else if (Value.Contains('L'))
{
SelectedCronType = CronTypes.LastOfPeriod;
if (_period == PeriodTypes.Week)
if (Period == PeriodTypes.Week)
{
CronItemData.LastPeriodOfWeek = int.Parse(Value[0].ToString());
}
Expand Down
3 changes: 2 additions & 1 deletion src/Masa.Blazor/Presets/Cron/Items/DayCronItem.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@

@code {

public DayCronItem() : base(PeriodTypes.Day)
public DayCronItem()
{
Period = PeriodTypes.Day;
}

protected override RenderFragment RadiosContent() => __builder =>
Expand Down
5 changes: 3 additions & 2 deletions src/Masa.Blazor/Presets/Cron/Items/HourCronItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

public partial class HourCronItem : SecondCronItem
{
public HourCronItem() : base(PeriodTypes.Hour)
public HourCronItem()
{
Period = PeriodTypes.Hour;
}
}
}
5 changes: 3 additions & 2 deletions src/Masa.Blazor/Presets/Cron/Items/MinuteCronItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

public partial class MinuteCronItem : SecondCronItem
{
public MinuteCronItem() : base(PeriodTypes.Minute)
public MinuteCronItem()
{
Period = PeriodTypes.Minute;
}
}
}
5 changes: 3 additions & 2 deletions src/Masa.Blazor/Presets/Cron/Items/MonthCronItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

public partial class MonthCronItem : SecondCronItem
{
public MonthCronItem() : base(PeriodTypes.Month)
public MonthCronItem()
{
Period = PeriodTypes.Month;
}
}
}
3 changes: 2 additions & 1 deletion src/Masa.Blazor/Presets/Cron/Items/SecondCronItem.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@

@code {

public SecondCronItem(PeriodTypes period = PeriodTypes.Second) : base(period)
public SecondCronItem()
{
Period = PeriodTypes.Second;
}

protected override RenderFragment RadiosContent() => __builder =>
Expand Down
3 changes: 2 additions & 1 deletion src/Masa.Blazor/Presets/Cron/Items/WeekCronItem.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@

@code {

public WeekCronItem() : base(PeriodTypes.Week)
public WeekCronItem()
{
Period = PeriodTypes.Week;
}

protected override RenderFragment RadiosContent() => __builder =>
Expand Down
3 changes: 2 additions & 1 deletion src/Masa.Blazor/Presets/Cron/Items/YearCronItem.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@

@code {

public YearCronItem() : base(PeriodTypes.Year)
public YearCronItem()
{
Period = PeriodTypes.Year;
}

protected override RenderFragment RadiosContent() => __builder =>
Expand Down
Loading