Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/simple loss #95

Merged
merged 5 commits into from
Dec 3, 2019
Merged

Feature/simple loss #95

merged 5 commits into from
Dec 3, 2019

Conversation

ktaaaki
Copy link
Collaborator

@ktaaaki ktaaaki commented Dec 2, 2019

Loss APIに関して基礎的な以下の修正を行った

  • 2つのlossのmin, maxを取るMinLoss, MaxLossを追加
  • Lossから初期化引数p, qを削除し,その機能を非公開クラスDivergenceに継承して分割
  • _get_evalをforwardにリネーム
  • ValueLossの評価値を初期化時そのままではなく,FloatTensorに変換(型変換の手間が減るため)

@masa-su masa-su merged commit 4930d56 into develop/v0.2.0 Dec 3, 2019
@masa-su masa-su deleted the feature/simple_loss branch December 3, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants