Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit init arg of exponential distributions #90

Merged
merged 3 commits into from
Nov 19, 2019

Conversation

ktaaaki
Copy link
Collaborator

@ktaaaki ktaaaki commented Oct 29, 2019

DistributionBase.__init__では可変長引数でtorchDistributionのパラメータを受け取っていて,NormalDistributionなどではその__init__をそのまま継承している.
これをそれぞれのパラメータに合わせた__init__に置き換えた.

期待できることには以下がある.

  • 存在しないパラメータが指定されることがなくなる
  • 開発ツールの補完でそれぞれの分布のパラメータを確認できる

@ktaaaki
Copy link
Collaborator Author

ktaaaki commented Oct 29, 2019

RelaxedCategoricalなどの引数の順序(温度,distributionの引数,Categoricalのパラメータ)は以前のままですが,分かりにくいかもしれません.

@masa-su masa-su merged commit 74fcb2c into develop/v0.1.4 Nov 19, 2019
@masa-su masa-su deleted the fix_init_arg_error branch November 19, 2019 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants