Skip to content
This repository was archived by the owner on May 5, 2024. It is now read-only.

Fix - Assets are uploaded as 34 byte #11

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

matteocodogno
Copy link
Contributor

@matteocodogno matteocodogno commented Dec 18, 2019

The octokitLogger function overwrote the file contents, to avoid that we make a defensive copy.

Close issue #10

@matteocodogno matteocodogno force-pushed the feature/bug#10 branch 2 times, most recently from 9f86d28 to 3938627 Compare December 18, 2019 15:19
@marvinpinto
Copy link
Owner

@matteocodogno Looking great! Ping me when you're ready for review & merge 👍

@matteocodogno matteocodogno force-pushed the feature/bug#10 branch 2 times, most recently from abcb551 to 3e804da Compare December 18, 2019 15:25
@matteocodogno
Copy link
Contributor Author

@marvinpinto I don't have idea why the keybase pipeline fails.
Should I do anything?

@marvinpinto
Copy link
Owner

@matteocodogno Nah ignore the Keybase pipeline. Only the ci one matters.

@marvinpinto marvinpinto merged commit 289e532 into marvinpinto:master Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants