Fix ra-input-rich-text dark theme compatibility #5113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated styles for ra-input-rich-text for better dark mode compatibility. Related issue can be found here: marmelab#5112
|
Thanks! Would you mind adding a screenshot in the PR description? |
Done |
|
Approved. You'll have to fix the eslint/prettier errors though |
djhi
changed the title
|
Thanks! |
fzaninotto
reviewed
Aug 5, 2020
| @@ -0,0 +1,621 @@ | |||
| { | |||
There was a problem hiding this comment.
this file should not have been committed. I'll remove it in a future commit.
fzaninotto
reviewed
Aug 5, 2020
| @@ -46,6 +46,7 @@ | |||
| "react-dom": "^16.9.0" | |||
| }, | |||
| "dependencies": { | |||
| "@material-ui/core": "^4.11.0", | |||
There was a problem hiding this comment.
not good: the ra-ui-material-ui dependency is ^4.3.3. This is a breaking change.
Why did you need an earlier version in the first place?
There was a problem hiding this comment.
I actually didn't change that. Linters were throwing error of @material-ui/core not being installed, So I installed it.
fzaninotto
added a commit
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated styles for ra-input-rich-text for better dark mode compatibility.
Fixes #5112
[EDIT]
Screenshots
Before:
After: