Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EmptyText Inconsistencies #4661

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Fix EmptyText Inconsistencies #4661

merged 1 commit into from
Apr 8, 2020

Conversation

jdemangeon
Copy link
Contributor

Closes #4648

@jdemangeon jdemangeon added the RFR Ready For Review label Apr 8, 2020
@jdemangeon jdemangeon mentioned this pull request Apr 8, 2020
Closed
fzaninotto
fzaninotto approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@fzaninotto fzaninotto merged commit 87249ad into master Apr 8, 2020
@fzaninotto fzaninotto deleted the fix-emptytext-inconsistencies branch April 8, 2020 10:43
@fzaninotto fzaninotto added this to the 3.4.1 milestone Apr 8, 2020
@dgarvin57
Copy link

Thanks for fixing this. I can confirm it's working properly in 3.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.

TextField with null value outputs "null" (as string)
4 participants
@jdemangeon @dgarvin57 @fzaninotto @JulienMattiussi