Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added autocomplete attribute to Password field on LoginForm.tsx #3666

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Added autocomplete attribute to Password field on LoginForm.tsx #3666

merged 1 commit into from
Oct 8, 2019

Conversation

UltimateForm
Copy link
Contributor

@UltimateForm UltimateForm commented Sep 10, 2019 •
edited by fzaninotto
Loading

djhi
djhi approved these changes Sep 10, 2019
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@ashim-kr-saha ashim-kr-saha mentioned this pull request Sep 10, 2019
Merged
3 tasks
@fzaninotto fzaninotto changed the title Added autocomplete attribute to Password field on LoginForm.tsx (see … Added autocomplete attribute to Password field on LoginForm.tsx Sep 11, 2019
@djhi djhi added this to the 2.9.8 milestone Oct 8, 2019
@djhi djhi merged commit 709780d into marmelab:master Oct 8, 2019
@christoph2806
Copy link

Seems this triggers a warning now: Warning: Invalid DOM property autocomplete. Did you mean autoComplete?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.8
Development

Successfully merging this pull request may close these issues.

Login: Possible Security Risk with DOM warning
3 participants
@UltimateForm @christoph2806 @djhi