Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create-react-admin does not ignore auth-provider when specified and using supabase #10533

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Feb 20, 2025

Problem

When specifying supabase as the --data-provider option and local as the --auth-provider option, create-react-admin says it will ignore the --auth-provider but actually doesn't.

How To Test

  • make build-create-react-admin install
  • /node_modules/.bin/create-react-admin myadmin --data-provider supabase --auth-provider local
  • check that the CLI does not mention anything about how to use the local auth provider
  • check that the generated app does not include a custom auth provider

Additional Checks

  • The PR targets master for a bugfix, or next for a feature

Also, please make sure to read the contributing guidelines.

@djhi djhi added the RFR Ready For Review label Feb 20, 2025
@slax57 slax57 self-requested a review February 20, 2025 17:02
@slax57 slax57 added this to the 5.6.1 milestone Feb 20, 2025
@slax57 slax57 merged commit 7b56a91 into master Feb 20, 2025
16 checks passed
@slax57 slax57 deleted the fix-create-react-admin-supabase-auth-provider branch February 20, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants