Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo] Fix build #10499

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[Demo] Fix build #10499

merged 1 commit into from
Feb 6, 2025

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Feb 6, 2025

Problem

Although the demo seems to build fine, it actually doesn't work when you run vite preview. It seems it loads multiple versions of react-router. This is only an issue in our monorepo setup.

Solution

Add aliases so that Vite correctly resolve the react-router versions we want in the demo (v7)

How To Test

  • make run-demo => check it runs fine in development
  • make build-demo => check it still builds fine
  • cd examples/demo && yarn preview => check the production build runs fine

Additional Checks

  • The PR targets master for a bugfix, or next for a feature

@djhi djhi added the RFR Ready For Review label Feb 6, 2025
@fzaninotto fzaninotto merged commit 6a56460 into master Feb 6, 2025
16 checks passed
@fzaninotto fzaninotto deleted the fix-demo-build branch February 6, 2025 17:18
@fzaninotto fzaninotto added this to the 5.5.4 milestone Feb 6, 2025
@fzaninotto fzaninotto changed the title Fix demo build [Demo] Fix build Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants