Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Although the demo seems to build fine, it actually doesn't work when you run
vite preview
. It seems it loads multiple versions ofreact-router
. This is only an issue in our monorepo setup.Solution
Add aliases so that Vite correctly resolve the react-router versions we want in the demo (v7)
How To Test
make run-demo
=> check it runs fine in developmentmake build-demo
=> check it still builds finecd examples/demo && yarn preview
=> check the production build runs fineAdditional Checks
master
for a bugfix, ornext
for a feature