Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create POST url documentation is inaccurate in ja-data-json-server package #5792

Closed
tjsturos opened this issue Jan 18, 2021 · 2 comments · Fixed by #5794
Closed

Create POST url documentation is inaccurate in ja-data-json-server package #5792

tjsturos opened this issue Jan 18, 2021 · 2 comments · Fixed by #5794
Labels
documentation good first issue

Comments

@tjsturos
Copy link
Contributor

image

In the create route, it says POST http://my.api.url/${resource}/${id} but it should POST http://my.api.url/${resource} as you wouldn't have the ID-- and the actual code backs this up:

image
@djhi
Copy link
Collaborator

djhi commented Jan 18, 2021

Good catch! Would you mind opening a pull request to fix it?

@tjsturos
Copy link
Contributor Author

tjsturos commented Jan 18, 2021 via email

tjsturos added a commit to tjsturos/react-admin that referenced this issue Jan 18, 2021
@tjsturos
Fix Create method API call URL example
0c025a7 
The Create method API url does not have an ID.  The resource is not
created yet.
Fixes marmelab#5792
@tjsturos tjsturos mentioned this issue Jan 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Doc] Fix Create method API call URL example in ra-data-json-server tjsturos/react-admin
2 participants
@djhi @tjsturos