Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong semantic in the sidebar menu #4968

Closed
Moinax opened this issue Jun 22, 2020 · 0 comments · Fixed by #4994
Closed

Wrong semantic in the sidebar menu #4968

Moinax opened this issue Jun 22, 2020 · 0 comments · Fixed by #4994
Assignees
Labels

Comments

@Moinax
Copy link

Moinax commented Jun 22, 2020

What you were expecting:
The logout button should appear as an html 'button' or all menu items should be li and be surrounded by a ul

What happened instead:
The logout button is an html li but is not surrounded by an html ul

Steps to reproduce:
Just look at the logout button in the sidebar

Related code:

<div class="MuiPaper-root MuiDrawer-paper MuiDrawer-paperAnchorLeft RaSidebar-drawerPaper-54 RaSidebar-drawerPaper-55 RaSidebar-drawerPaper-53 MuiPaper-elevation16" tabindex="-1" style="transform: none; transition: transform 225ms cubic-bezier(0, 0, 0.2, 1) 0ms;">
	<div class="RaMenu-main-113">
		<a class="MuiButtonBase-root MuiListItem-root MuiMenuItem-root RaMenuItemLink-root-114 MuiMenuItem-gutters MuiListItem-gutters MuiListItem-button" tabindex="-1" role="menuitem" aria-disabled="false" href="/">
			<div class="MuiListItemIcon-root RaMenuItemLink-icon-116">
				<svg class="MuiSvgIcon-root" focusable="false" viewBox="0 0 24 24" role="img">
					<path d="M3 13h8V3H3v10zm0 8h8v-6H3v6zm10 0h8V11h-8v10zm0-18v6h8V3h-8z"></path>
					<title>Dashboard</title>
				</svg>
			</div>Dashboard
			<span class="MuiTouchRipple-root"></span>
		</a>
		<a aria-current="page" class="MuiButtonBase-root MuiListItem-root MuiMenuItem-root RaMenuItemLink-root-114 MuiMenuItem-gutters MuiListItem-gutters MuiListItem-button RaMenuItemLink-active-115" tabindex="-1" role="menuitem" aria-disabled="false" href="/employees">
			<div class="MuiListItemIcon-root RaMenuItemLink-icon-116">
				<svg width="22" height="20" viewBox="0 0 22 20" fill="none" titleAccess="Employees">
					<path fill-rule="evenodd" clip-rule="evenodd" d="M14 9H16C16 7.62 14.849 6.593 13.371 6.059C14.061 5.418 14.5 4.513 14.5 3.5C14.5 1.57 12.93 0 11 0C9.07 0 7.5 1.57 7.5 3.5C7.5 4.513 7.939 5.418 8.629 6.059C7.151 6.593 6 7.62 6 9H8C8 8.402 9.413 7.643 11 7.643C12.587 7.643 14 8.402 14 9ZM12.5 3.5C12.5 2.673 11.827 2 11 2C10.173 2 9.5 2.673 9.5 3.5C9.5 4.327 10.173 5 11 5C11.827 5 12.5 4.327 12.5 3.5Z" fill="#BDBDBD"></path>
					<path fill-rule="evenodd" clip-rule="evenodd" d="M7.371 17.059C8.061 16.418 8.5 15.513 8.5 14.5C8.5 12.57 6.93 11 5 11C3.07 11 1.5 12.57 1.5 14.5C1.5 15.513 1.939 16.418 2.629 17.059C1.151 17.593 0 18.62 0 20H2C2 19.402 3.413 18.643 5 18.643C6.587 18.643 8 19.403 8 20H10C10 18.62 8.849 17.593 7.371 17.059ZM6.5 14.5C6.5 13.673 5.827 13 5 13C4.173 13 3.5 13.673 3.5 14.5C3.5 15.327 4.173 16 5 16C5.827 16 6.5 15.327 6.5 14.5Z" fill="#BDBDBD"></path>
					<path fill-rule="evenodd" clip-rule="evenodd" d="M20.5 14.5C20.5 15.513 20.061 16.418 19.371 17.059C20.849 17.593 22 18.62 22 20H20C20 19.403 18.587 18.643 17 18.643C15.413 18.643 14 19.402 14 20H12C12 18.621 13.151 17.593 14.629 17.059C13.939 16.418 13.5 15.513 13.5 14.5C13.5 12.57 15.07 11 17 11C18.93 11 20.5 12.57 20.5 14.5ZM18.5 14.5C18.5 13.673 17.827 13 17 13C16.173 13 15.5 13.673 15.5 14.5C15.5 15.327 16.173 16 17 16C17.827 16 18.5 15.327 18.5 14.5Z" fill="#BDBDBD"></path>
				</svg>
			</div>Employees
			<span class="MuiTouchRipple-root"></span>
		</a>
		<li class="MuiButtonBase-root MuiListItem-root MuiMenuItem-root logout RaLogout-menuItem-117 MuiMenuItem-gutters MuiListItem-gutters MuiListItem-button" tabindex="-1" role="menuitem" aria-disabled="false">
			<div class="MuiListItemIcon-root RaLogout-icon-118">
				<svg class="MuiSvgIcon-root" focusable="false" viewBox="0 0 24 24" aria-hidden="true">
					<path d="M13 3h-2v10h2V3zm4.83 2.17l-1.42 1.42C17.99 7.86 19 9.81 19 12c0 3.87-3.13 7-7 7s-7-3.13-7-7c0-2.19 1.01-4.14 2.58-5.42L6.17 5.17C4.23 6.82 3 9.26 3 12c0 4.97 4.03 9 9 9s9-4.03 9-9c0-2.74-1.23-5.18-3.17-6.83z"></path>
				</svg>
			</div>Logout
			<span class="MuiTouchRipple-root"></span>
		</li>
	</div>
</div>

Environment

  • React-admin version: <= 3.6.1
  • Last version that did not exhibit the issue (if applicable):
  • React version: latest
  • Browser: chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants