Change to join values together rather than use length

as this ensures if the size doesn't change, but the values do the update fires Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
marmelab · Aug 4, 2020 · ba7f0d3 · ba7f0d3
1 parent 45bda72
commit ba7f0d3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/ra-ui-materialui/src/input/AutocompleteArrayInput.spec.tsx b/packages/ra-ui-materialui/src/input/AutocompleteArrayInput.spec.tsx
@@ -396,7 +396,7 @@ describe('<AutocompleteArrayInput />', () => {
             expect(setFilter).toHaveBeenCalledWith('p');
             formApi.change('tags', ['p']);
             await waitForDomChange();
-            expect(setFilter).toHaveBeenCalledTimes(2);
+            expect(setFilter).toHaveBeenCalledTimes(3);
             expect(setFilter).toHaveBeenCalledWith('');
         });
 
@@ -432,7 +432,7 @@ describe('<AutocompleteArrayInput />', () => {
             expect(setFilter).toHaveBeenCalledWith('p');
             formApi.change('tags', ['p']);
             await waitForDomChange();
-            expect(setFilter).toHaveBeenCalledTimes(2);
+            expect(setFilter).toHaveBeenCalledTimes(3);
             expect(setFilter).toHaveBeenCalledWith('');
         });
 

diff --git a/packages/ra-ui-materialui/src/input/AutocompleteArrayInput.tsx b/packages/ra-ui-materialui/src/input/AutocompleteArrayInput.tsx
@@ -217,7 +217,7 @@ const AutocompleteArrayInput: FunctionComponent<
     // would have to first clear the input before seeing any other choices
     useEffect(() => {
         handleFilterChange('');
-    }, [values.length, handleFilterChange]);
+    }, [values.join(','), handleFilterChange]);
 
     const handleKeyDown = useCallback(
         (event: React.KeyboardEvent) => {