Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tab-separated inputs in marian-server #649

Merged
merged 6 commits into from
Jul 26, 2020
Merged

Support tab-separated inputs in marian-server #649

merged 6 commits into from
Jul 26, 2020

Conversation

snukky
Copy link
Member

@snukky snukky commented May 1, 2020

Description

This replaces #505 and adds support for the --tsv option into marian-server. Other tools already support this options.

It also fixes --max-length and --max-length-crop in marian-server as the original pull request.

Added dependencies: none

How to test

See added regression tests: marian-nmt/marian-regression-tests#55

Checklist

  • I have tested the code manually
  • I have run regression tests
  • I have read and followed CONTRIBUTING.md
  • I have updated CHANGELOG.md

emjotde
emjotde approved these changes Jul 25, 2020
View reviewed changes
Copy link
Member

@emjotde emjotde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks. Good catch that TextInput was missing max-length and max-length-crop.

@snukky snukky merged commit 41de4f3 into master Jul 26, 2020
@snukky snukky deleted the input-tsv-server branch April 12, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emjotde emjotde emjotde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snukky @emjotde @tomekd