Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement outbound flow control #42

Merged
merged 11 commits into from
Mar 27, 2019
Merged

Implement outbound flow control #42

merged 11 commits into from
Mar 27, 2019

Conversation

marcoferrer
Copy link
Owner

Prevent excessive buffering on the outbound stream observer using manual flow control

@codecov-io
Copy link

codecov-io commented Mar 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@a1129f6). Click here to learn what that means.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop     #42   +/-   ##
=========================================
  Coverage           ?   88.8%           
  Complexity         ?      19           
=========================================
  Files              ?      14           
  Lines              ?     259           
  Branches           ?      37           
=========================================
  Hits               ?     230           
  Misses             ?      10           
  Partials           ?      19
Impacted Files Coverage Δ Complexity Δ
...s/coroutines/client/ClientResponseStreamChannel.kt 100% <100%> (ø) 9 <9> (?)
...rrer/krotoplus/coroutines/server/ServerChannels.kt 88.88% <100%> (ø) 0 <0> (?)
...ithub/marcoferrer/krotoplus/coroutines/RpcUtils.kt 87.5% <100%> (ø) 0 <0> (?)
...oferrer/krotoplus/coroutines/client/ClientCalls.kt 96.29% <100%> (ø) 0 <0> (?)
...otoplus/coroutines/client/ClientBidiCallChannel.kt 100% <100%> (ø) 0 <0> (?)
...rcoferrer/krotoplus/coroutines/call/FlowControl.kt 80% <76.47%> (ø) 0 <0> (?)
.../marcoferrer/krotoplus/coroutines/call/CallExts.kt 88.57% <80%> (ø) 0 <0> (?)
...utines/call/FlowControlledInboundStreamObserver.kt 82.6% <82.6%> (ø) 0 <0> (?)
...us/coroutines/client/ClientStreamingCallChannel.kt 85.71% <85.71%> (ø) 0 <0> (?)
...oferrer/krotoplus/coroutines/server/ServerCalls.kt 86.07% <90%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1129f6...c7a09a7. Read the comment docs.

@marcoferrer marcoferrer merged commit 3f970a8 into develop Mar 27, 2019
marcoferrer added a commit that referenced this pull request Apr 3, 2019
* prevent outbound buffering with flow control

* add coroutine start param to launchProducerJob

* remove redundant call to disableAutoInboundFlowControl

* add assertion for deferred response completion in onComplete
@marcoferrer marcoferrer deleted the outbound-flow-control branch April 9, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants