Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile desktop with the current code #919

Closed
robnorber opened this issue Aug 16, 2024 · 3 comments · Fixed by #922
Closed

Compile desktop with the current code #919

robnorber opened this issue Aug 16, 2024 · 3 comments · Fixed by #922

Comments

@robnorber
Copy link

The desktop version uses 1.7, and doesn't work for me at all (produces errors). I want to compile it with the current code that's in the main branch. How do I do it?
@HarelM
Copy link
Collaborator

HarelM commented Aug 16, 2024

You'll need to figure this out, desktop code was moved here but never got to production state.
It shouldn't be complicated though as it uses electron...

@robnorber
Copy link
Author

Is it possible to use the Docker image with a local json?

@HarelM
Copy link
Collaborator

HarelM commented Aug 17, 2024

This was the idea in the past, I don't know if it's possible now without fixing the code.
If this is your use case you are welcome to try and help 😃

kevinschaul added a commit to kevinschaul/maputnik that referenced this issue Aug 26, 2024
@kevinschaul
Update desktop build to pull from this repo
1c73831 
Previously the desktop build lived in a separate repo and had to
download a released version of the maputnik editor source code. Now that
both live in the same repo, the desktop version can simply run the
maputnik build command and use those generated files.

This commit also removes the ci-desktop workflow, which is not needed.
The regular ci workflow already built the desktop version (this commit
also fixes that build).

Fixes maplibre#919
@kevinschaul kevinschaul mentioned this issue Aug 26, 2024
Merged
@HarelM HarelM closed this as completed in 66c5a5c Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update desktop build to pull from this repo kevinschaul/maputnik
2 participants
@HarelM @robnorber