-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Added "Tileset > Edit Tileset Image Parameters..." action #4034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@CodiumAI-Agent /review (just curious what feedback it might have) |
PR Reviewer Guide 🔍(Review updated until commit c8a7cda)Here are some key observations to aid the review process:
|
Oh well, the agent failed to understand a line was added to a function rather than a "duplicate" being added. For a moment I thought it might have caught the duplication between |
6cbab90
to
ff8289c
Compare
ff8289c
to
8f0e937
Compare
This makes the functionality easier to discover. Previously editing the tileset image parameters was only possible by clicking the value of the Image property in the Properties view, and then the appearing "Edit" button.
8f0e937
to
c8a7cda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/tiled/tileseteditor.h:95
- [nitpick] Consider renaming 'editTilesetParametersAction' (and related functions) to 'editTilesetImageParametersAction' for consistency with the UI label 'Edit Tileset Image Parameters...'.
QAction *editTilesetParametersAction() const;
Persistent review updated to latest commit c8a7cda |
This makes the functionality easier to discover. Previously editing the tileset image parameters was only possible by clicking the value of the Image property in the Properties view, and then the appearing "Edit" button.