Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit US locale to String.Format of bouding box #973

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Add explicit US locale to String.Format of bouding box #973

merged 2 commits into from
Feb 19, 2019

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Feb 18, 2019

Closes #972

@tobrun tobrun self-assigned this Feb 18, 2019
@tobrun tobrun requested review from devotaaabel and osana February 18, 2019 10:01
devotaaabel
devotaaabel reviewed Feb 18, 2019
View reviewed changes
Copy link
Contributor

@devotaaabel devotaaabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @tobrun, looks good once local.properties is removed

@tobrun tobrun merged commit 999d26a into master Feb 19, 2019
@tobrun tobrun deleted the tvn-locale branch February 19, 2019 16:47
@osana osana mentioned this pull request Apr 11, 2019
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devotaaabel devotaaabel devotaaabel left review comments

@LukasPaczos LukasPaczos LukasPaczos left review comments

@osana osana osana approved these changes

Assignees

@tobrun tobrun

Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobrun @devotaaabel @LukasPaczos @osana